Hi. On Mon, 3 Dec 2018 at 00:42, Simon Goldschmidt <simon.k.r.goldschm...@gmail.com> wrote: > > On Mon, Dec 3, 2018 at 8:27 AM Kever Yang <kever.y...@rock-chips.com> wrote: > > > > Hi Tom, > > > > With this merge, my boards can't work correctly in SPL, the console > > output is mess up. > > > > I have test on rk3229 and rk3399 boards, and finally I identify that > > below patch is the root cause: > > > > 6f57c34473 serial: ns16550: fix debug uart putc called before init > > Henri Roosen reported this to me last week. The root cause seems to be > that the ns16550 baudrate prescaler is read as 0 on his rk3399 board. > > He helped me try an additional fix but that didn't work either. > > So we can either try and fix this if it is only a problem for rockchip > boards or revert the patch and I'll think of a different solution to > fix this issue (debug uart putc called before init) for the socfpga > platform. > > I still think it would be good to fix this globally: there's nothing > keeping us from accidentally adding putc code before the debug uart is > initialized and this is something that should be detected, I think.
I think it would be better to have this discussion on the patch rather than the pull request. Regards, Simon [..] _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot