Hi Simon, On Sun, 2018-12-09 at 18:44 -0700, Simon Glass wrote: > This converts the following to Kconfig: > CONFIG_BOARD_TYPES > > Signed-off-by: Simon Glass <s...@chromium.org> > --- > > arch/arm/mach-exynos/Kconfig | 8 ++++++++ > configs/odroid-xu3_defconfig | 2 +- > configs/odroid_defconfig | 2 +- > include/configs/axs10x.h | 1 - > include/configs/hsdk.h | 1 -
Please note ARC boards have nothing to do with Samsung Exynos. They are based on ARC cores and "arch/arm/mach-exynos/Kconfig" makes no sense for them. Moreover I'm not sure why CONFIG_BOARD_TYPES is an Exynos-specific option. That said why don't we move CONFIG_BOARD_TYPES to the generic Kconfig? > include/configs/odroid.h | 1 - > include/configs/odroid_xu3.h | 1 - > scripts/config_whitelist.txt | 1 - > 8 files changed, 10 insertions(+), 7 deletions(-) [snip] > diff --git a/include/configs/axs10x.h b/include/configs/axs10x.h > index 1b2966fd612..a1b9e7b21d9 100644 > --- a/include/configs/axs10x.h > +++ b/include/configs/axs10x.h > @@ -34,7 +34,6 @@ > /* > * This board might be of different versions so handle it > */ There's no reason to keep above comment if "#define" below is gone. > -#define CONFIG_BOARD_TYPES > > /* > * NAND Flash configuration > diff --git a/include/configs/hsdk.h b/include/configs/hsdk.h > index cdf4fddd940..b1af1271777 100644 > --- a/include/configs/hsdk.h > +++ b/include/configs/hsdk.h > @@ -35,7 +35,6 @@ > /* > * This board might be of different versions so handle it > */ Ditto. But then it turned out in case of HSDK CONFIG_BOARD_TYPES is just a copy-paste from AXS10x and "gd->board_type" is not used. That said this hunk is applicable but I may do it myself separately. > -#define CONFIG_BOARD_TYPES > > /* > * UART configuration -Alexey _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot