On 19-01-15 11:10:51, Tom Rini wrote: > On Tue, Jan 15, 2019 at 04:05:43PM +0000, Abel Vesa wrote: > > On 19-01-15 11:02:09, Tom Rini wrote: > > > On Tue, Jan 15, 2019 at 11:07:23AM +0000, Abel Vesa wrote: > > > > > > > Some boards might need USB_STORAGE enabled in u-boot proper but not in > > > > SPL. > > > > Make a separate config for SPL and keep the same depends on conditions > > > > but for SPL. > > > > > > > > Signed-off-by: Abel Vesa <abel.v...@nxp.com> > > > > --- > > > > common/Makefile | 2 +- > > > > configs/apalis_imx6_defconfig | 1 + > > > > configs/colibri_imx6_defconfig | 1 + > > > > configs/mx6sabresd_defconfig | 1 + > > > > drivers/usb/Kconfig | 8 ++++++++ > > > > 5 files changed, 12 insertions(+), 1 deletion(-) > > > > > > The root problem here, as I discovered today digging in another patch is > > > that in essence CONFIG_SPL_USB_SUPPORT is mis-named and should be > > > CONFIG_SPL_USB_STORAGE and all cases in Makefiles of > > > > I think those too are two separete thing. You can have SPL_USB_SUPPORT > > enabled, > > but the SPL_USB_STORAGE disabled. For example, for SDP support in SPL > > you need SPL_USB_SUPPORT, but you don't need the SPL_USB_STORAGE. So, > > IMO, they need to remain two separate things. > > No, you can't. Or rather, the option names are a bit confusing. > CONFIG_SPL_USB_SUPPORT controls common/spl/spl_usb.c and that will not > function without CONFIG_USB_STORAGE support as it's specifically about > loading from a device. It's also only set for some TI AM43xx platforms > as the ROM there supports booting from USB sticks and in turn we have > SPL doing so. CONFIG_SPL_USB_HOST_SUPPORT is different and is set on > both AM43xx and various NXP platforms and is what you're after, without > the storage support side. > > Aside, what is the USB host case on i.MX? It's not acting in host mode > when being passed U-Boot via imx_usb, is it?
For imx_usb, SDP is used (CONFIG_SPL_USB_SDP_SUPPORT) which is under CONFIG_SPL_USB_GADGET (not CONFIG_SPL_USB_SUPPORT or CONFIG_SPL_USB_HOST_SUPPORT). So you're right, CONFIG_SPL_USB_SUPPORT has nothing to do with SDP. > > -- > Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot