Hi Tom > -----Original Message----- > From: Tom Rini <[email protected]> > Sent: 15 March 2019 16:08 > To: Ibai Erkiaga Elorza <[email protected]> > Cc: Alexander Graf <[email protected]>; [email protected]; Sumit Garg > <[email protected]>; Heinrich Schuchardt <[email protected]>; Albert > Aribaud <[email protected]> > Subject: Re: [U-Boot][PATCH v2] arm: fix hvc call > > On Fri, Mar 15, 2019 at 12:13:11PM +0000, Ibai Erkiaga Elorza wrote: > > Hi Alex, > > > > > -----Original Message----- > > > From: Alexander Graf <[email protected]> > > > Sent: 25 February 2019 13:09 > > > To: Ibai Erkiaga Elorza <[email protected]> > > > Cc: [email protected]; Sumit Garg <[email protected]>; > > > Heinrich Schuchardt <[email protected]>; Tom Rini > > > <[email protected]>; Albert Aribaud <[email protected]> > > > Subject: Re: [U-Boot][PATCH v2] arm: fix hvc call > > > > > > > > > > > > > Am 25.02.2019 um 02:11 schrieb Ibai Erkiaga <ibai.erkiaga- > > > [email protected]>: > > > > > > > > HVC call makes use of 6 mandatory arguments rather than 7 in the > > > > same way as SMC calls. The 7th argument is optional (Client ID) > > > > for both HVC and SMC but is implemented as 16-bit parameter and > > > > register R7 or W7. The aim of this patch is just fix compilation > > > > error due to an invalid asm code in the HVC call so that's why the 7th > argument is removed. > > > > > > > > The issue does not report any error in a normal build as hvc_call > > > > is not used at all and is optimized by the compiler. Using -O0 > > > > triggers the error so the patch is intended to fix issues on a > > > > ongoing effor to build U-Boot with -O0. > > > > > > > > Signed-off-by: Ibai Erkiaga <[email protected]> > > > > > > Reviewed-by: Alexander Graf <[email protected]> > > > > Thanks for the review. Do I need to CC somebody else to the patch be > accepted? > > No, but I'm inclined currently to take for for the next release rather than > right > now, unless there's an important argument I'm missing? Which happens more > than I'd care to admit ;) > No rush, I'm pretty new contributor and just wondering if something else was missing after Alexander's Review.
> -- > Tom Ibai _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
