On 4/4/19 8:10 AM, Ashish Kumar wrote: > > >> -----Original Message----- >> From: Vignesh Raghavendra <[email protected]> >> Sent: Tuesday, April 2, 2019 10:04 AM >> To: Marek Vasut <[email protected]>; [email protected] >> Cc: Marek Vasut <[email protected]>; Horatiu Vultur >> <[email protected]>; Jagan Teki <[email protected]>; Simon >> Goldschmidt <[email protected]>; Stefan Roese <[email protected]>; >> Ashish Kumar <[email protected]> >> Subject: Re: [PATCH] mtd: spi: Replace ad-hoc default implementation with >> spi_mem_op >> >> + Ashish, >> >> On 02/04/19 6:22 AM, Marek Vasut wrote: >>> Replace the ad-hoc erase operation implementation with a simple >>> spi_mem_op implementation of the same functionality. This is a minor >>> optimization and removal of the ad-hoc code. >>> >>> This however also changes the behavior of the execution of the erase >>> opcode from two separate transfer requests to the SPI NOR driver to >>> one transfer request to the SPI NOR driver. The former was how U-Boot >>> behaved before the SPI NOR framework was imported and the later was >>> introduced by the SPI NOR framework. The former is more optimal, so >>> keep that. >>> >>> Signed-off-by: Marek Vasut <[email protected]> >>> Cc: Horatiu Vultur <[email protected]> >>> Cc: Jagan Teki <[email protected]> >>> Cc: Simon Goldschmidt <[email protected]> >>> Cc: Stefan Roese <[email protected]> >>> Cc: Vignesh R <[email protected]> >>> --- >> >> Marek, thanks for the fix! >> >> Jagan, >> >> Could we get this merged before v2019.04 release as this should fix >> regression >> wrt erase reported by Ashish. > > > Yes, follow patch reverts back to old method of erase implementation. > Tested-by: Ashish Kumar <[email protected]>
I guess this never made it into the release, so the SPI NOR erase is broken in v2019.04 ? -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
