On 12/04/19 10:46 AM, Jagan Teki wrote:
>>>> >>>> On 02/04/19 6:22 AM, Marek Vasut wrote: >>>>> Replace the ad-hoc erase operation implementation with a simple >>>>> spi_mem_op implementation of the same functionality. This is a minor >>>>> optimization and removal of the ad-hoc code. >>>>> >>>>> This however also changes the behavior of the execution of the erase >>>>> opcode from two separate transfer requests to the SPI NOR driver to >>>>> one transfer request to the SPI NOR driver. The former was how U-Boot >>>>> behaved before the SPI NOR framework was imported and the later was >>>>> introduced by the SPI NOR framework. The former is more optimal, so >>>>> keep that. >>>>> >>>>> Signed-off-by: Marek Vasut <marek.vasut+rene...@gmail.com> >>>>> Cc: Horatiu Vultur <horatiu.vul...@microchip.com> >>>>> Cc: Jagan Teki <ja...@openedev.com> >>>>> Cc: Simon Goldschmidt <simon.k.r.goldschm...@gmail.com> >>>>> Cc: Stefan Roese <s...@denx.de> >>>>> Cc: Vignesh R <vigne...@ti.com> >>>>> --- >>>> >>>> Marek, thanks for the fix! >>>> >>>> Jagan, >>>> >>>> Could we get this merged before v2019.04 release as this should fix >>>> regression >>>> wrt erase reported by Ashish. >>> >>> >>> Yes, follow patch reverts back to old method of erase implementation. >>> Tested-by: Ashish Kumar <ashish.ku...@nxp.com> >> >> I guess this never made it into the release, so the SPI NOR erase is >> broken in v2019.04 ? > > I usually review on top of patchwork, that seems not assigned to me. > Vignesh will this break? I can see the erase seems fine on my microzed > with last week testing. > This issue affects SPI controllers that try to interpret spi_xfer() calls back into cmd+addr+data format instead of just sending dout over the bus as is. So, it does not all SPI controllers. From a quick look fsl-qspi, renesas_rpc_spi and mtk_qspi maybe affected. This is a valid fix. Would be great if this patch is part of early pull request -- Regards Vignesh _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot