On Mon, Nov 19, 2018 at 1:42 AM Miquel Raynal <[email protected]> wrote: > > A Coverity robot reported an integer handling issue > (OVERFLOW_BEFORE_WIDEN) in the potentially overflowing expression: > > (mtd_div_by_ws(mtd->size, mtd) - mtd_div_by_ws(offs, mtd)) * > mtd_oobavail(mtd, ops) > > While such overflow will certainly never happen due to the numbers > handled, it is cleaner to fix this operation anyway. > > The problem is that all the maths include 32-bit quantities, while the > result is stored in an explicit 64-bit value. > > As maxooblen will just be compared with a size_t, let's change the > type of the variable to a size_t. This will not fix anything but will > clarify a bit the situation. Then, do an explicit cast to fix Coverity > warning. > > Addresses-Coverity-ID: 184180 ("Integer handling issues") > Signed-off-by: Miquel Raynal <[email protected]> > ---
Applied to u-boot-spi/master _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
