Hi Prabhakar, Please see my reply inline.
> -----Original Message----- > From: Prabhakar Kushwaha > Sent: 2019年5月21日 16:23 > To: Bin Meng <bmeng...@gmail.com>; Andy Tang <andy.t...@nxp.com> > Cc: Simon Glass <s...@chromium.org>; Tom Rini <tr...@konsulko.com>; > Sudhanshu Gupta <sudhanshu.gu...@nxp.com>; U-Boot Mailing List > <u-boot@lists.denx.de>; Ran Wang <ran.wan...@nxp.com>; Bhaskar > Upadhaya <bhaskar.upadh...@nxp.com> > Subject: RE: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP > LS1028A SoC support > > > > > For example, the "config ARCH_LS1028A" selects the following I2C > > > > components: > > > > > > > > + select SYS_I2C_MXC > > > > + select SYS_I2C_MXC_I2C1 > > > > + select SYS_I2C_MXC_I2C2 > > > > + select SYS_I2C_MXC_I2C3 > > > > + select SYS_I2C_MXC_I2C4 > > > > + select SYS_I2C_MXC_I2C5 > > > > + select SYS_I2C_MXC_I2C6 > > > > + select SYS_I2C_MXC_I2C7 > > > > + select SYS_I2C_MXC_I2C8 > > > > > > > > These I2C# macros look to me this is not DM based. For DM such > > > > stuff is determined from the DT automatically. > > > Agree. Our I2C IP owner is working on it and will change all I2C > > > driver to DM > > based. > > > > Great. > > Andy: Please make sure our I2C IP owner do change all NXP supported SoCs > including LS1028A. Patch for DM-based i2c driver is ready. Will send out this week. Then there are follow up patches to convert all the platforms. Thanks, Andy > > > > > > > > > > > > > > For ls1028a_serdes.c, we probably need create serdes uclass driver for > it. > > > We don't have serdes dts node in both uboot and kernel. So I think > > > we can > > leave it as it is. > > > > I see. Then let's keep it as it is. > > > > > > > > > > > > > For arch/arm/cpu/armv8/fsl-layerscape/cpu.c, can we create a CPU > > > > driver for it? I see lots of CONFIG_XXX_BASE and CONFIG_XXX_SIZE > > > > in this file that come from > > > > arch/arm/include/asm/arch-fsl-layerscape/cpu.h? Can't we get such > > > > in > > DT? > > > Agree. But this affects all our platforms and need big efforts. Many > > components are involved in it. > > > We will convert it step by step. > > > > > > > Sounds you already have a plan, which is good! > > > > I will prefer to merge this patch-set for now. > > I will keep CPU DM model in my todo. It will require change in many NXP > supported devices. > > --pk > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot