Dear Brian Cavagnolo,

In message <[email protected]> you wrote:
> 
> Signed-off-by: Brian Cavagnolo <[email protected]>
> Signed-off-by: Andrey Yurovsky <[email protected]>
> ---
>  drivers/serial/Makefile        |    1 +
>  drivers/serial/serial_pollux.c |  116 
> ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 117 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/serial/serial_pollux.c

Please see previous comments about using C structs with I/O accessors,
coding style etc.

General question: do we really need a new UART driver, or can this be
generalized with other drivers?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
"Unix is simple, but it takes a genius to understand the simplicity."
                                                     - Dennis Ritchie
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to