On Tue, Jun 1, 2010 at 3:42 PM, Wolfgang Denk <[email protected]> wrote: > Dear Brian Cavagnolo, > > In message <[email protected]> you wrote: >> >> Signed-off-by: Brian Cavagnolo <[email protected]> >> Signed-off-by: Andrey Yurovsky <[email protected]> >> --- >> drivers/serial/Makefile | 1 + >> drivers/serial/serial_pollux.c | 116 >> ++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 117 insertions(+), 0 deletions(-) >> create mode 100644 drivers/serial/serial_pollux.c > > Please see previous comments about using C structs with I/O accessors, > coding style etc.
Understood. > General question: do we really need a new UART driver, or can this be > generalized with other drivers? The s3c44b0 serial hardware is quite similar to that of the pollux. There are some quirks (e.g., the pollux's registers are 16 bits and the s3c44b0's are 32), but I think there are some reasonable ways to address that. I'll use that driver in v2. Thanks, Brian _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
