On Thu, Jul 25, 2019 at 1:08 PM Marek Vasut <ma...@denx.de> wrote: > > On 7/24/19 8:09 PM, Simon Goldschmidt wrote: > > On Wed, Jul 24, 2019 at 9:48 AM Marek Vasut <ma...@denx.de> wrote: > >> > >> On 7/24/19 9:43 AM, Simon Goldschmidt wrote: > >>> On Wed, Jul 24, 2019 at 9:31 AM Marek Vasut <ma...@denx.de> wrote: > >>>> > >>>> On 7/23/19 10:27 PM, Simon Goldschmidt wrote: > >>>>> To use this timer on socfpga as system tick, it needs to take itself out > >>>>> of reset. > >>>>> > >>>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschm...@gmail.com> > >>>>> --- > >>>>> > >>>>> drivers/timer/dw-apb-timer.c | 18 +++++++++++++++++- > >>>>> 1 file changed, 17 insertions(+), 1 deletion(-) > >>>>> > >>>>> diff --git a/drivers/timer/dw-apb-timer.c b/drivers/timer/dw-apb-timer.c > >>>>> index 86312b8dc7..fad22be8c9 100644 > >>>>> --- a/drivers/timer/dw-apb-timer.c > >>>>> +++ b/drivers/timer/dw-apb-timer.c > >>>>> @@ -8,6 +8,7 @@ > >>>>> #include <common.h> > >>>>> #include <dm.h> > >>>>> #include <clk.h> > >>>>> +#include <reset.h> > >>>>> #include <timer.h> > >>>>> > >>>>> #include <asm/io.h> > >>>>> @@ -18,7 +19,8 @@ > >>>>> #define DW_APB_CTRL 0x8 > >>>>> > >>>>> struct dw_apb_timer_priv { > >>>>> - fdt_addr_t regs; > >>>>> + fdt_addr_t regs; > >>>>> + struct reset_ctl_bulk resets; > >>>>> }; > >>>>> > >>>>> static int dw_apb_timer_get_count(struct udevice *dev, u64 *count) > >>>>> @@ -42,6 +44,12 @@ static int dw_apb_timer_probe(struct udevice *dev) > >>>>> struct clk clk; > >>>>> int ret; > >>>>> > >>>>> + ret = reset_get_bulk(dev, &priv->resets); > >>>>> + if (ret) > >>>>> + dev_warn(dev, "Can't get reset: %d\n", ret); > >>>> > >>>> Shouldn't this be printed by the subsystem ? > >>> > >>> I don't think it's printed by the subsystem. Plus I don't know if it's > >>> a warning for all drivers? I also haven't really thought about that, as > >>> I just copied the reset handling code from another driver... > >> > >> Hmmmm, I guess we cannot operate without clock anyway, so it should be > >> dev_err(). And I guess it's indeed not a subsystem print afterall. > > > > Well, for gen5, it would be dev_err. I'm not sure about arria10 and > > stratix10 though? I think at least stratix10 doesn't have a clock driver, > > yet. > > But it does have reset driver, doesn't it ?
Yes it does. You confused me with saying "we cannot operate without clock anyway", but this is about reset. So yes, you're right, dev_err() is better. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot