Hi Ramon Thank you for first review,answers below...
Am 5. August 2019 08:33:11 MESZ schrieb Ramon Fried <rfried....@gmail.com>: >> --- a/drivers/pci/Kconfig >> +++ b/drivers/pci/Kconfig >> @@ -145,4 +145,12 @@ config PCI_MVEBU >> Say Y here if you want to enable PCIe controller support on >> Armada XP/38x SoCs. >> >> +config PCIE_MEDIATEK >> + bool "MediaTek PCIe controller" >> + depends on DM_PCI >> + depends on ARCH_MEDIATEK >> + help >> + Say Y here if you want to enable PCIe controller support on >> + MediaTek SoCs. >This is too generic, is there a version number ? who is the IP vendor >behind that Mediatek PCIe ? on which mediatek SoCs ? It is designed to be a generic driver,but currently only mt7623 is supported/tested.others can be added in future >> + /* disable interrupt */ >> + val = readl(pcie->base + PCIE_INT_ENABLE); >> + val &= ~PCIE_PORT_INT_EN(port->slot); >> + writel(val, pcie->base + PCIE_INT_ENABLE); >You might want to consider using setbits_le32/clrbits_le32. We will check this Regards Frank _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
