Hi, > -----Original Message----- > From: Michal Simek <[email protected]> > Sent: Tuesday, September 17, 2019 6:56 PM > To: Simon Glass <[email protected]>; Bin Meng <[email protected]> > Cc: Michal Simek <[email protected]>; U-Boot Mailing List <u- > [email protected]>; T Karthik Reddy <[email protected]>; git > <[email protected]> > Subject: Re: [PATCH v2 1/2] dm: core: Add functions to read 64-bit dt > properties > > On 17. 09. 19 7:47, Simon Glass wrote: > > On Mon, 2 Sep 2019 at 09:24, Bin Meng <[email protected]> wrote: > >> > >> On Mon, Sep 2, 2019 at 10:34 PM Michal Simek > <[email protected]> wrote: > >>> > >>> From: T Karthik Reddy <[email protected]> > >>> > >>> This patch adds functions dev_read_u64_default & dev_read_u64 to > >>> read unsigned 64-bit values from devicetree. > >>> > >>> Signed-off-by: T Karthik Reddy <[email protected]> > >>> Signed-off-by: Michal Simek <[email protected]> > >>> --- > >>> > >>> Changes in v2: > >>> - Moved newly added 64-bit funtion definations & prototypes below > >>> 32-bit functions. > >>> > >>> drivers/core/ofnode.c | 2 +- > >>> drivers/core/read.c | 10 ++++++++++ > >>> include/dm/ofnode.h | 2 +- > >>> include/dm/read.h | 33 +++++++++++++++++++++++++++++++++ > >>> 4 files changed, 45 insertions(+), 2 deletions(-) > >>> > >> > >> Reviewed-by: Bin Meng <[email protected]> > > > > How about adding a few tests for these new functions? > > > > See for example here: > > > > https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl > > ab.denx.de%2Fu-boot%2Fcustodians%2Fu-boot- > dm%2Fcommit%2F63453b90049cef > > > 10309f254c35d8a33e1e6552ba&data=02%7C01%7Ctkarthik%40xilinx.co > m%7C > > > 3e117e8ac64647d1c85c08d73b72c06e%7C657af505d5df48d08300c31994686c5 > c%7C > > > 0%7C1%7C637043236369808223&sdata=MQJnMjJlj6QHbMQ%2Fz77bXjd > BkfiGFXa > > YAbnISGTKR3A%3D&reserved=0 > > It shouldn't be a problem to put some u64 properties and read them back. > > Karthik: Can you please take a look at it?
Okay. Regards T karthik > > Thanks, > Michal _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
