On 10/15/19 5:18 AM, AKASHI Takahiro wrote:
On Sat, Oct 12, 2019 at 03:02:09PM +0200, Heinrich Schuchardt wrote:
On 10/11/19 9:55 AM, AKASHI Takahiro wrote:
I hope this patch set will be reviewed promptly as I'm aiming to
push my "UEFI secure boot" patch for v2020.01.

How can I make all of these new files being built to check for build

As always in my case of UEFI secure boot, they have gone through build and
run/tests as part of UEFI secure boot. This is also true for RSA
extension as UEFI secure boot is the only user of those features.

Did you run them through Travis?

Please note that almost of all the code here come from the latest
linux code without any changes. A few changes that I made are
quite U-Boot/UEFI-secure-boot specific and is *best* tested through
UEFI secure boot test.

That said, you can at least build the code by enabling
   Library routines
     Security support
       Asymmetric Key Support

Please, provide unit tests for the patch series.

As I said above, it will be exercised and tested under UEFI secure boot

If there is nothing I can test now, I would not know how to evaluate
these patches.

There is good reason that we have unit tests and don't simply say U-Boot
can be tested by booting Linux.

Please, provide a documentation how these different tools and files work

What do you mean by different tools?
Asn1 compiler and what?
Do you want to have doc/README.asn1compiler?

This patch series provides some puzzle pieces but doesn't tell me how
they fit together. Maybe a README describing the different elements
provided for UEFI secure boot would be most appropriate.

Best regards


-Takahiro Akashi

Best regards


U-Boot mailing list

Reply via email to