Re: [PATCH 01/10] arm: mvebu: fix SerDes table alignment

[Stefan Roese]

On 11.01.20 20:36, Joel Johnson wrote:

Tested on Solidrun ClearFog Base. Table alignment was:
  | Lane #  | Speed |  Type       |
  --------------------------------
  |   0    |  3   |  SATA0       |
  |   1    |  0   |  SGMII1      |
  |   2    |  3   |  SATA1       |
  |   3    |  5   |  USB3 HOST1  |
  |   4    |  5   |  USB3 HOST0  |
  |   5    |  4   |  SGMII2      |
  --------------------------------

After the change, it's correctly aligned as:
  | Lane # | Speed |  Type       |
  --------------------------------
  |   0    |   3   | SATA0       |
  |   1    |   0   | SGMII1      |
  |   2    |   5   | PCIe1       |
  |   3    |   5   | USB3 HOST1  |
  |   4    |   5   | PCIe2       |
  |   5    |   0   | SGMII2      |
  --------------------------------

Signed-off-by: Joel Johnson <mrj...@lixil.net>
---

  arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c 
b/arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c
index 33e70569bc..66409a50c0 100644
--- a/arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c
+++ b/arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c
@@ -1366,16 +1366,16 @@ static void print_topology_details(const struct 
serdes_map *serdes_map,

DEBUG_INIT_S("board SerDes lanes topology details:\n"); - DEBUG_INIT_S(" | Lane # | Speed | Type |\n");

+       DEBUG_INIT_S(" | Lane # | Speed |  Type       |\n");
        DEBUG_INIT_S(" --------------------------------\n");
        for (lane_num = 0; lane_num < count; lane_num++) {
                if (serdes_map[lane_num].serdes_type == DEFAULT_SERDES)
                        continue;
                DEBUG_INIT_S(" |   ");
                DEBUG_INIT_D(hws_get_physical_serdes_num(lane_num), 1);
-               DEBUG_INIT_S("    |  ");
+               DEBUG_INIT_S("    |   ");
                DEBUG_INIT_D(serdes_map[lane_num].serdes_speed, 2);
-               DEBUG_INIT_S("   |  ");
+               DEBUG_INIT_S("   | ");
                DEBUG_INIT_S((char *)
                             serdes_type_to_string[serdes_map[lane_num].
                                                   serdes_type]);

Reviewed-by: Stefan Roese <s...@denx.de>

Thanks,
Stefan