On 2/2/20 12:40 PM, Marek Vasut wrote: > On 2/2/20 6:23 PM, Sean Anderson wrote: >> CONFIG_DESIGNWARE_WATCHDOG is only defined if CONFIG_HW_WATCHDOG is >> defined, and this is never defined in headers (or in the defconfigs). > > This is what I see in socfpga_soc64_common.h on u-boot/master: > 153 #ifdef CONFIG_SPL_BUILD > 154 #define CONFIG_HW_WATCHDOG
Huh, there it is. I guess I expected the usage to be the same as socfpga_common.h. Would it be best to add DESIGNWARE_WATCHDOG to the appropriate Kconfigs, defconfigs, or leave it in the header? > >>> The patch is wrong, see above. Also, it's missing a SoB line. >> >> Ah, I just noticed that, thanks for pointing that out. > > Note that I updated u-boot-socfpga/master and sent a PR just now (thanks > for reminding me of that), it contains the DW WDT patches that were > posted to the ML some time ago. You want to rebase the series on top of > that. Ok, I will do that for v2. --Sean
