On 2/2/20 12:15 PM, Marek Vasut wrote: > On 2/2/20 6:10 PM, Sean Anderson wrote: >> Currently this is set from headers. No board has this set by default > > Please check where socfpga_common.h and socfpga_soc64_common.h are > included. This should then make it clear that this statement in not true. > > , so we >> don't need to modify any configs.
CONFIG_DESIGNWARE_WATCHDOG is only defined if CONFIG_HW_WATCHDOG is defined, and this is never defined in headers (or in the defconfigs). > The patch is wrong, see above. Also, it's missing a SoB line. Ah, I just noticed that, thanks for pointing that out.

