On 2/3/20 10:11 AM, Simon Glass wrote: > Hi Marek, > > On Mon, 3 Feb 2020 at 01:28, Marek Vasut <[email protected]> wrote: >> How could this be reviewed if it's missing basic things, like a SoB line ?
I added that in a reply to the original patch; again my apologies for missing it the first time around. > > I saw you requested that on another patch. Apart from that it looks OK to me. > > People should use patman :-) I usually add my signed-off-by lines with git rebase --sign, but I forgot to do that this time. Though reasonably the thing which should have reminded me was running checkpatch (which I also forgot to run). > Regards, > Simon >

