On Sun, 23 Feb 2020 23:08:25 +0530 Manivannan Sadhasivam <[email protected]> wrote:
Hi Amit, > On Sat, Jan 25, 2020 at 05:52:51PM +0530, Amit Singh Tomar wrote: > > Right now, Clock bindings for ethernet uses different names(even in Linux) > > CLK_ETH_MAC for S900 and CLK_ETHERNET for S700, It causes compilation > > problem > > when using them for common clock driver. > > > > Let's use same name CLK_ETHERNET for both S700 and S900. So are you changing the include file that you just imported from Linux? I don't think that's a good idea, as you start to divert from the kernel in a subtle way. And especially the header files should stay unchanged. So either you send this patch to the kernel first, or, probably better, you drop this change here, and unify the name at the point where it's used (#ifndef CLK_ETHERNET ....) Cheers, Andre. > > > > Signed-off-by: Amit Singh Tomar <[email protected]> > > Reviewed-by: Manivannan Sadhasivam <[email protected]> > > Thanks, > Mani > > > --- > > Changes since v2: > > * Newly added patch, not there in v2/v1. > > --- > > include/dt-bindings/clock/actions,s900-cmu.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/dt-bindings/clock/actions,s900-cmu.h > > b/include/dt-bindings/clock/actions,s900-cmu.h > > index 7c12515..2247f1c 100644 > > --- a/include/dt-bindings/clock/actions,s900-cmu.h > > +++ b/include/dt-bindings/clock/actions,s900-cmu.h > > @@ -121,7 +121,7 @@ > > #define CLK_DDR1 97 > > #define CLK_DMM 98 > > > > -#define CLK_ETH_MAC 99 > > +#define CLK_ETHERNET 99 > > #define CLK_RMII_REF 100 > > > > #define CLK_NR_CLKS (CLK_RMII_REF + 1) > > -- > > 2.7.4 > >
