> -----Original Message----- > From: Marek Vasut <[email protected]> > Sent: Sunday, March 1, 2020 11:12 PM > To: Tan, Ley Foon <[email protected]>; [email protected] > Cc: Simon Goldschmidt <[email protected]>; Ley Foon Tan > <[email protected]>; See, Chin Liang <[email protected]>; Chee, > Tien Fong <[email protected]> > Subject: Re: [PATCH] arm: socfpga: arria10: Add save_boot_params() > > On 2/26/20 8:01 PM, Ley Foon Tan wrote: > [...] > > +#define BOOTROM_SHARED_MEM_ADDR > (CONFIG_SYS_INIT_RAM_ADDR + 0x40000 \ > > + - 0x800) > > +#define RST_STATUS_SHARED_ADDR > (BOOTROM_SHARED_MEM_ADDR + 0x438) > > Are all these magic values needed or is there some more descriptive macro > name available for them ? 0x40000 is onchip ram size and 0x800 is 2KB size. I can convert these to 2 macos. > > > +u32 rst_mgr_status __section(.data); > > static u32 ... ? Other files might want to use this.
Thanks. Regards Ley Foon
