> -----Original Message----- > From: Marek Vasut <[email protected]> > Sent: Friday, March 6, 2020 8:43 AM > To: Tan, Ley Foon <[email protected]>; Ley Foon Tan > <[email protected]> > Cc: [email protected]; Simon Goldschmidt > <[email protected]>; See, Chin Liang > <[email protected]>; Chee, Tien Fong <[email protected]> > Subject: Re: [PATCH] arm: socfpga: arria10: Add save_boot_params() > > On 3/6/20 1:33 AM, Tan, Ley Foon wrote: > [...] > >>>>>>>> Aren't those already defined in > include/configs/socfpga_common.h ? > >>>>>>> socfpga_common.h have this: > >>>>>>> #define CONFIG_SYS_INIT_RAM_SIZE (0x40000 - > >>>>>> CONFIG_SYS_SPL_MALLOC_SIZE) > >>>>>>> > >>>>>>> But, we can't use it here. > >>>>>> > >>>>>> Why ? > >>>>> CONFIG_SYS_INIT_RAM_SIZE is minus with > >> CONFIG_SYS_SPL_MALLOC_SIZE, not 256KB (0x40000). > >>>> > >>>> Then define the init ram size macro somewhere in > >>>> arch/arm/mach-socfpga/include and use it in both the configs/ and > >>>> your code ? :) > >>> Look at existing header files under arch/arm/mach-socfpga/include/, > >>> can add to base_addr_a10.h. > >> > >> Isn't that base address common to A10 and CV/AV ? > > No, CV/AV uses base_addr_ac5.h. > > Then it might make sense to define the macro in both. Okay.
Regards Ley Foon
