Hi Sean, On Thu, 19 Mar 2020 at 23:37, Sean Anderson <[email protected]> wrote: > > By default, patman outputs a line for every edition of the series in every > patch, regardless of whether any changes were made. This can result in many > redundant lines in patch changelogs, especially when a patch did not exist > before a certain revision. For example, the default behaviour could result > in a changelog of > > Changes in v6: > - Make a change > > Changes in v5: None > > Changes in v4: > - New > > Changes in v3: None > Changes in v2: None > Changes in v1: None > > With this patch applied and with --no-empty-changes, the same patch would > look like > > Changes in v6: > - Make a change > > Changes in v4: > - New > > This is entirely aesthetic, but I think it reduces clutter, especially for > patches added later on in a series. > > Signed-off-by: Sean Anderson <[email protected]> > --- > > tools/patman/func_test.py | 2 +- > tools/patman/patchstream.py | 15 ++++++++------- > tools/patman/patman.py | 7 +++++-- > tools/patman/series.py | 12 +++++++----- > tools/patman/test.py | 2 +- > 5 files changed, 22 insertions(+), 16 deletions(-)
I can see the value here, particularly for the 'new' case. But I actually appreciate the positive confirmation that nothing changed. Sometimes people send patches and fail to add a change log. What happens if a patch has no changes at all since v1? Do you think we should always report 'None' for the last version? Regards, Simon
