On 3/21/20 3:17 PM, Simon Glass wrote: > Hi Sean, > > On Sat, 21 Mar 2020 at 12:44, Sean Anderson <[email protected]> wrote: >> >> On 3/21/20 10:42 AM, Simon Glass wrote: >>> Hi Sean, >>> >>> I can see the value here, particularly for the 'new' case. But I >>> actually appreciate the positive confirmation that nothing changed. >>> Sometimes people send patches and fail to add a change log. >> >> Hm, I don't know if this patch would affect that. If there are no >> "Series-changes" tags, we just get nothing (vs. a bunch of "None"s). >> >>> What happens if a patch has no changes at all since v1? Do you think >>> we should always report 'None' for the last version? >> >> In my opinion, I think we should report nothing. Of course, this patch >> is entirely for aesthetics. It's perfectly valid to do one thing or >> another. In my patches, I like to emulate what I would write if I was >> doing it by hand. > > But as a reviewer, for a v2...n patchset I really do want to see a > change log. If nothing has changed I want to know that, and the > absence of a change log is not enough to convince me that there are no > changes. > > While you have structured your patch as an option, it would be better > to make it the default, so long as we can avoid confusion. > > Perhaps we should have something like '(no changes since v1)' added in > this case? > > Regards, > Simon >
That sounds good. --Sean
