Hi Tom, > On Jun 2, 2020, at 6:02 AM, Tom Rini <[email protected]> wrote: > > On Mon, Jun 01, 2020 at 07:44:25PM -0700, Alex Nemirovsky wrote: > >> From: Aaron Tseng <[email protected]> >> >> Add Cortina Access Ethernet device driver for CAxxxx SoCs. >> This driver supports both legacy and DM_ETH network models. >> >> Signed-off-by: Aaron Tseng <[email protected]> >> Signed-off-by: Alex Nemirovsky <[email protected]> >> >> CC: Joe Hershberger <[email protected]> >> CC: Abbie Chang <[email protected]> >> CC: Tom Rini <[email protected]> > [snip] >> +#define HEADER_A_SIZE 8 >> +#define CORTINA_NI_DBG 1 >> +/*define CORTINA_NI_DBG if individual rx,tx,init needs to be called */ > > We have pr_debug, etc, please use those and not a custom debug defiine. > >> +#ifdef CONFIG_DM_ETH >> +#if CORTINA_NI_DBG >> +static struct udevice *dbg_dev; >> +#endif >> +static struct udevice *curr_dev; >> +#else > > The deadline for drivers to convert to DM for ethernet is v2020.07. > Please rework to not introduce any legacy mode support. Thanks!
For clarity, we are providing BOTH DM and Legacy mode support in our driver. Is the request to REMOVE Legacy mode support, even though DM support is already provided to meet the 2020.07 requirement? > > -- > Tom
