On 9/30/20 2:24 PM, Lad Prabhakar wrote:
> commit 7c8f821e ("i2c: rcar_i2c: Set the slave address from
> rcar_i2c_xfer") blindly called rcar_i2c_set_addr() with read argument
> always set to 1 during xfer which introduced read/write errors, whereas
> earlier rcar_i2c_read_common() called rcar_i2c_set_addr() with read set to
> 1 and rcar_i2c_write_common() called rcar_i2c_set_addr() with read set 0.
It would be good to explain in the commit message why the previous code
was correct.
> Fixes: 7c8f821e ("i2c: rcar_i2c: Set the slave address from rcar_i2c_xfer")
> Signed-off-by: Lad Prabhakar <[email protected]>
Reviewed-by: Marek Vasut <[email protected]>
[...]
