Hi Ley Foon,
> -----Original Message-----
> From: Tan, Ley Foon <[email protected]>
> Sent: Monday, January 18, 2021 3:34 PM
> To: Lim, Elly Siew Chin <[email protected]>; [email protected]
> Cc: Marek Vasut <[email protected]>; See, Chin Liang
> <[email protected]>; Simon Goldschmidt
> <[email protected]>; Chee, Tien Fong
> <[email protected]>; Westergreen, Dalon
> <[email protected]>; Simon Glass <[email protected]>; Gan, Yau
> Wai <[email protected]>
> Subject: RE: [v2 6/6] configs: socfpga: Add defconfig for Agilex with VAB
> support
>
>
>
> > -----Original Message-----
> > From: Lim, Elly Siew Chin <[email protected]>
> > Sent: Thursday, January 7, 2021 6:04 PM
> > To: [email protected]
> > Cc: Marek Vasut <[email protected]>; Tan, Ley Foon
> > <[email protected]>; See, Chin Liang <[email protected]>;
> > Simon Goldschmidt <[email protected]>; Chee, Tien Fong
> > <[email protected]>; Westergreen, Dalon
> > <[email protected]>; Simon Glass <[email protected]>; Gan,
> > Yau Wai <[email protected]>; Lim, Elly Siew Chin
> > <[email protected]>
> > Subject: [v2 6/6] configs: socfpga: Add defconfig for Agilex with VAB
> > support
> >
> > Booting Agilex with Vendor Authorized Boot.
> >
> > Signed-off-by: Siew Chin Lim <[email protected]>
> >
> > ---
> > v2
> > ---
> > - Renamed CONFIG_SECURE_VAB_AUTH to
> > CONFIG_SOCFPGA_SECURE_VAB_AUTH
> > - Add BOOTCOMMAND macro in defconfig
> > ---
> > .../{socfpga_agilex_atf_defconfig => socfpga_agilex_vab_defconfig} | 5
> > +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-) copy
> > configs/{socfpga_agilex_atf_defconfig => socfpga_agilex_vab_defconfig}
> > (92%)
> >
> > diff --git a/configs/socfpga_agilex_atf_defconfig
> > b/configs/socfpga_agilex_vab_defconfig
> > similarity index 92%
> > copy from configs/socfpga_agilex_atf_defconfig
> > copy to configs/socfpga_agilex_vab_defconfig
> > index 704a9d56b9..1e28efea5e 100644
> > --- a/configs/socfpga_agilex_atf_defconfig
> > +++ b/configs/socfpga_agilex_vab_defconfig
> > @@ -1,5 +1,4 @@
> > CONFIG_ARM=y
> > -CONFIG_ARM_SMCCC=y
> > CONFIG_SPL_LDSCRIPT="arch/arm/mach-socfpga/u-boot-spl-soc64.lds"
> > CONFIG_ARCH_SOCFPGA=y
> > CONFIG_SYS_TEXT_BASE=0x200000
> > @@ -8,6 +7,7 @@ CONFIG_ENV_SIZE=0x1000
> > CONFIG_ENV_OFFSET=0x200
> > CONFIG_DM_GPIO=y
> > CONFIG_NR_DRAM_BANKS=2
> > +CONFIG_SOCFPGA_SECURE_VAB_AUTH=y
> > CONFIG_TARGET_SOCFPGA_AGILEX_SOCDK=y
> > CONFIG_IDENT_STRING="socfpga_agilex"
> > CONFIG_SPL_FS_FAT=y
> > @@ -15,12 +15,13 @@ CONFIG_SPL_TEXT_BASE=0xFFE00000 CONFIG_FIT=y
> > CONFIG_SPL_LOAD_FIT=y
> > CONFIG_SPL_LOAD_FIT_ADDRESS=0x02000000
> > +# CONFIG_LEGACY_IMAGE_FORMAT is not set
> > # CONFIG_USE_SPL_FIT_GENERATOR is not set
> > CONFIG_BOOTDELAY=5
> > CONFIG_USE_BOOTARGS=y
> > CONFIG_BOOTARGS="earlycon"
> > CONFIG_USE_BOOTCOMMAND=y
> > -CONFIG_BOOTCOMMAND="run fatscript; run mmcfitload; run
> > linux_qspi_enable; run mmcfitboot"
> > +CONFIG_BOOTCOMMAND="run fatscript; run mmcfitload; run mmcfitboot"
>
> Don't need "run linux_qspi_enable"?
In VAB flow, " linux_qspi_enable" will be handled in board_prep_linux function.
+#ifdef CONFIG_CADENCE_QSPI
+ if (env_get("linux_qspi_enable"))
+ run_command(env_get("linux_qspi_enable"), 0);
+#endif
>
> Regards
> Ley Foon
