Hi Bin, On Thu, 8 Apr 2021 at 14:59, Bin Meng <bmeng...@gmail.com> wrote: > > Hi Simon, > > On Wed, Apr 7, 2021 at 12:33 PM Simon Glass <s...@chromium.org> wrote: > > > > Use VENDOR_COREBOOT instead of TARGET_COREBOOT so we can have multiple > > coreboot boards, sharing options. Only SYS_CONFIG_NAME needs to be > > defined TARGET_COREBOOT. > > > > I am not sure what use case this is? This change makes no difference > when U-Boot is built as a coreboot payload.
This is because I want to add another coreboot board, called 'chromeos_coreboot'. So in that case it will have VENDOR_COREBOOT enabled, but not TARGET_COREBOOT. > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > arch/x86/cpu/coreboot/Kconfig | 2 +- > > board/coreboot/coreboot/Kconfig | 12 ++++++++---- > > 2 files changed, 9 insertions(+), 5 deletions(-) > > > > Regards, > Bin Depending on a particular TARGET Kconfig is not a good idea, IMO. Regards, Simon