On 6/8/21 12:35 PM, Lokesh Vutla wrote:
>
>
> On 07/06/21 7:47 pm, Vignesh Raghavendra wrote:
>> This series add DMA support for R5 SPL on J721e/J7200 SoCs post HSM
>> Rearch.
>>
>> Depends on Tero's base HSM rearch support series.
>>
>> v2:
>> Use IS_ENABLED() consistentially instead of #ifdef
>> Reword commit msg for 5/7 as suggested by Lokesh
>> Rebase on Tero's latest HSM base series.
>
> I see the folloiwing build warnings with this series:
>
> arch/arm/dts/k3-j7200-common-proc-board.dtb: Warning (reg_format):
> /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000:reg: property has invalid
> length (80 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/dts/k3-j7200-common-proc-board.dtb: Warning
> (avoid_default_addr_size):
> /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000: Relying on default
> #address-cells value
> arch/arm/dts/k3-j7200-common-proc-board.dtb: Warning
> (avoid_default_addr_size):
> /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000: Relying on default
> #size-cells value
> arch/arm/dts/k3-j7200-common-proc-board.dtb: Warning
> (avoid_default_addr_size):
> /bus@100000/bus@28380000/mcu-navss/dma-controller@285c0000: Relying on default
> #address-cells value
> arch/arm/dts/k3-j7200-common-proc-board.dtb: Warning
> (avoid_default_addr_size):
> /bus@100000/bus@28380000/mcu-navss/dma-controller@285c0000: Relying on default
> #size-cells value
> arch/arm/dts/k3-j7200-r5-common-proc-board.dtb: Warning (reg_format):
> /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000:reg: property has invalid
> length (80 bytes) (#address-cells == 2, #size-cells == 1)
> arch/arm/dts/k3-j7200-r5-common-proc-board.dtb: Warning
> (avoid_default_addr_size):
> /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000:
> Relying on default #address-cells value
> arch/arm/dts/k3-j7200-r5-common-proc-board.dtb: Warning
> (avoid_default_addr_size):
> /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000:
> Relying on default #size-cells value
> arch/arm/dts/k3-j7200-r5-common-proc-board.dtb: Warning
> (avoid_default_addr_size):
> /bus@100000/bus@28380000/mcu-navss/dma-controller@285c0000: Relying on default
> #address-cells value
> arch/arm/dts/k3-j7200-r5-common-proc-board.dtb: Warning
> (avoid_default_addr_size):
> /bus@100000/bus@28380000/mcu-navss/dma-controller@285c0000: Relying on default
> #size-cells value
>
> Can you fix it or send me fix, Ill can squash?
Hmm, weird. I had to fix #address-cells and #size-cells in
k3-j7200-common-proc-board-u-boot.dtsi but they same does not seem to be
needed for j721e. Anyway below diff fixes the warning
Could you squash to 5/7?
diff --git a/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
b/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
index 41ce9fcb59..786cc48050 100644
--- a/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
+++ b/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
@@ -43,6 +43,8 @@
mcu-navss{
u-boot,dm-spl;
+ #address-cells = <2>;
+ #size-cells = <2>;
ringacc@2b800000 {
reg = <0x0 0x2b800000 0x0 0x400000>,
Regards
Vignesh
