On Tue, Aug 24, 2021 at 06:05:10PM -0700, Troy Kisky wrote: > On 8/24/2021 5:41 PM, Tom Rini wrote: > > Move the CONFIG_DDR_MB symbol to Kconfig. A later clean-up would be to > > make dynamic memory size detection work based on how this is done on > > other i.MX6 platforms. > > > > Cc: Troy Kisky <[email protected]> > > Signed-off-by: Tom Rini <[email protected]> > > --- > > For example, mx6cuboxi does dynamic memory size detection and that code > > could be adapted for this platform and perhaps moved to a more generic > > imx6 location. > > --- > > board/boundary/nitrogen6x/Kconfig | 3 +++ > > configs/marsboard_defconfig | 1 - > > configs/mx6qsabrelite_defconfig | 3 ++- > > configs/nitrogen6dl2g_defconfig | 2 +- > > configs/nitrogen6dl_defconfig | 2 +- > > configs/nitrogen6q2g_defconfig | 2 +- > > configs/nitrogen6q_defconfig | 2 +- > > configs/nitrogen6s1g_defconfig | 2 +- > > configs/nitrogen6s_defconfig | 2 +- > > configs/riotboard_defconfig | 1 - > > 10 files changed, 11 insertions(+), 9 deletions(-) > > > > diff --git a/board/boundary/nitrogen6x/Kconfig > > b/board/boundary/nitrogen6x/Kconfig > > index f4db56d49601..9c176c071e72 100644 > > --- a/board/boundary/nitrogen6x/Kconfig > > +++ b/board/boundary/nitrogen6x/Kconfig > > @@ -9,4 +9,7 @@ config SYS_VENDOR > > config SYS_CONFIG_NAME > > default "nitrogen6x" > > > > +config DDR_MB > > + int "Memory size in MB" > > + > > endif > > > > > diff --git a/configs/marsboard_defconfig b/configs/marsboard_defconfig > > index bcb83b5d73de..8fcb16c108d1 100644 > > --- a/configs/marsboard_defconfig > > +++ b/configs/marsboard_defconfig > > @@ -11,7 +11,6 @@ CONFIG_TARGET_EMBESTMX6BOARDS=y > > CONFIG_DM_GPIO=y > > CONFIG_DEFAULT_DEVICE_TREE="imx6q-marsboard" > > CONFIG_DISTRO_DEFAULTS=y > > -CONFIG_SYS_EXTRA_OPTIONS="DDR_MB=1024" > > CONFIG_BOOTCOMMAND="run finduuid; run distro_bootcmd" > > # CONFIG_CONSOLE_MUX is not set > > CONFIG_SYS_CONSOLE_IS_IN_ENV=y > > > +++ b/configs/riotboard_defconfig > > @@ -18,7 +18,6 @@ CONFIG_SPL_SERIAL_SUPPORT=y > > CONFIG_SPL=y > > CONFIG_SPL_LIBDISK_SUPPORT=y > > CONFIG_DISTRO_DEFAULTS=y > > -CONFIG_SYS_EXTRA_OPTIONS="DDR_MB=1024" > > CONFIG_BOOTCOMMAND="run finduuid; run distro_bootcmd" > > # CONFIG_CONSOLE_MUX is not set > > CONFIG_SYS_CONSOLE_IS_IN_ENV=y > > > > > I guess marsboard_defconfig/riotboard_defconfig was a copy/paste issue, and > never needed DDR_MB=1024 ?
Correct. > For boundary boards > Acked-by: Troy Kisky <[email protected]> Thanks! -- Tom
signature.asc
Description: PGP signature
