Hi Simon On Wed, 2021-10-06 at 20:18 -0600, Simon Glass wrote: > ... > Nice clean-up!
Thanks! > Reviewed-by: Simon Glass <[email protected]> > > Option below. > > > > > diff --git a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi > > b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi > > index a97626fa0c1..0c65070cd5f 100644 > > --- a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi > > +++ b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi > > @@ -1,11 +1,15 @@ > > // SPDX-License-Identifier: GPL-2.0+ OR MIT > > /* > > - * Copyright 2020 Toradex > > + * Copyright 2020-2021 Toradex > > */ > > > > #include "imx8mm-u-boot.dtsi" > > > > / { > > + binman: binman { > > + multiple-images; > > + }; > > + > > firmware { > > optee { > > compatible = "linaro,optee-tz"; > > @@ -91,3 +95,121 @@ > > &wdog1 { > > u-boot,dm-spl; > > }; > > + > > +&binman { > > + u-boot-spl-ddr { > > + filename = "u-boot-spl-ddr.bin"; > > + pad-byte = <0xff>; > > + align-size = <4>; > > + align = <4>; > > + > > + u-boot-spl { > > + align-end = <4>; > > + }; > > + > > + blob_1: blob-ext@1 { > > + filename = "lpddr4_pmu_train_1d_imem.bin"; > > + size = <0x8000>; > > + }; > > You can use the 'type' if you like, so you don't need the @: > > blob_1: 1d-imem { > type = "blob-ext"; > filename = "..."; > ... Yeah, remember, we agreed on doing such further clean-up in a separate step once we migrated towards using a common binman configuration [1]. I am about to send out a v2 thereof. [1] https://marc.info/?l=u-boot&m=162998010613817 > Regards, > Simon Cheers Marcel
