Hi Samuel, On Wed, 22 Dec 2021 at 15:37, Samuel Dionne-Riel <[email protected]> wrote: > > Signed-off-by: Samuel Dionne-Riel <[email protected]> > --- > drivers/vibrator/Kconfig | 16 ++++ > drivers/vibrator/Makefile | 1 + > drivers/vibrator/vibrator_gpio.c | 122 +++++++++++++++++++++++++++++++ > 3 files changed, 139 insertions(+) > create mode 100644 drivers/vibrator/vibrator_gpio.c >
Reviewed-by: Simon Glass <[email protected]> This is fine...but I suggest in future code it might be a good idea to use log_msg_ret() when returning errors. This helps people figure out where they came from. Regards, Simon
