Dear Heiko Schocher, In message <[email protected]> you wrote: > as discussed in thread > http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/76654 > > and as a result of this discussion Michael Zaidman > proposed to create a genutils.h, see: > > http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/78692 > > So, introduce this genutils.h, as BUILD_BUG_ON is also > needed in sensor support. > > Signed-off-by: Heiko Schocher <[email protected]> > cc: Michael Zaidman <[email protected]> > --- > maybe I should include genutils.h in common.h ? > > include/genutils.h | 30 ++++++++++++++++++++++++++++++
I do not like the idea of adding yet another nonstandard header file with just a few definitions in it. Linux defines this is include/linux/kernel.h, i. e. in a pretty central place, and we should porobably do the same. How about adding it to include/common.h instead? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] The only way to get rid of a temptation is to yield to it. - Oscar Wilde _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
