On 2/13/23 00:13, Simon Glass wrote:
Hi,

On Sat, 11 Feb 2023 at 14:48, Marek Vasut <[email protected]> wrote:

Move the board_interface_eth_init() into common ethernet uclass code,
since this function could be shared by multiple drivers.

Signed-off-by: Marek Vasut <[email protected]>
---
Cc: "Ariel D'Alessandro" <[email protected]>
Cc: "NXP i.MX U-Boot Team" <[email protected]>
Cc: Andrey Zhizhikin <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Joe Hershberger <[email protected]>
Cc: Lukasz Majewski <[email protected]>
Cc: Marcel Ziswiler <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Michael Trimarchi <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Ramon Fried <[email protected]>
Cc: Sean Anderson <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: Tim Harvey <[email protected]>
Cc: Tommaso Merciai <[email protected]>
Cc: [email protected]
---
V3: New patch
---
  drivers/net/dwc_eth_qos.c | 7 -------
  net/eth-uclass.c          | 7 +++++++
  2 files changed, 7 insertions(+), 7 deletions(-)

Reviewed-by: Simon Glass <[email protected]>

Related, we do have a way of adding code to run when a device is
probed (events). Should we look at using that? Is it better or worse
than weak functions?

No, the next step here would be to figure out what to do with the GPR register programming, that'd be likely syscon or similar, but that's for another series.

Reply via email to