On 4/17/23 20:22, Ralph Siemsen wrote:
Hi Marek,
On Mon, Apr 17, 2023 at 07:02:34PM +0200, Marek Vasut wrote:
On 3/8/23 21:26, Ralph Siemsen wrote:
diff --git a/drivers/clk/renesas/Makefile b/drivers/clk/renesas/Makefile
index 8f82a7aa3e..a0d8c10bdb 100644
--- a/drivers/clk/renesas/Makefile
+++ b/drivers/clk/renesas/Makefile
@@ -1,6 +1,5 @@
-obj-$(CONFIG_CLK_RENESAS) += renesas-cpg-mssr.o
obj-$(CONFIG_CLK_RCAR_CPG_LIB) += rcar-cpg-lib.o
-obj-$(CONFIG_CLK_RCAR_GEN2) += clk-rcar-gen2.o
+obj-$(CONFIG_CLK_RCAR_GEN2) += clk-rcar-gen2.o renesas-cpg-mssr.o
Why not move the renesas-cpg-mssr.o into
obj-$(CONFIG_CLK_RCAR_CPG_LIB) line instead ?
I think this would break the build for gen2 devices, because they make
calls to CPG functions (eg. renesas_clk_endisable from clk-rcar-gen2.c),
however Kconfig only selects CPG lib for gen3.
Good point
Perhaps we could change Kconfig to select CPG also for gen2. I can make
this patch, but how to test that this does not introduce any new
problems? Might there be an autobuilder for R-Car somewhere?
You could introduce CONFIG_CLK_RCAR Kconfig symbol and use that for
renesas-cpg-mssr.o . Would that work ?
