Hi Bin: On 09:12 Mon 29 May , Bin Meng wrote: > On Sat, May 27, 2023 at 9:41 PM Yixun Lan <[email protected]> wrote: > > > > Hi Guo, Jisheng: > > > > On 11:36 Sat 27 May , Guo Ren wrote: > > > On Fri, May 26, 2023 at 8:41 PM Yixun Lan <[email protected]> wrote: > > > > > > > > Add support for Sipeed's Lichee Pi 4A board which based on > > > > T-HEAD's TH1520 SoC, only minimal device tree and serial onsole are > > > > enabled, > > > > so it's capable of chain booting from T-HEAD's vendor u-boot. > > > > > > > > Reviewed-by: Wei Fu <[email protected]> > > > > Signed-off-by: Yixun Lan <[email protected]> > > > > --- > > > > arch/riscv/Kconfig | 5 ++++ > > > > board/thead/th1520_lpi4a/Kconfig | 42 ++++++++++++++++++++++++++++ > > > > board/thead/th1520_lpi4a/MAINTAINERS | 7 +++++ > > > > board/thead/th1520_lpi4a/Makefile | 5 ++++ > > > > board/thead/th1520_lpi4a/board.c | 14 ++++++++++ > > > > include/configs/th1520_lpi4a.h | 22 +++++++++++++++ > > > > 6 files changed, 95 insertions(+) > > > > create mode 100644 board/thead/th1520_lpi4a/Kconfig > > > > create mode 100644 board/thead/th1520_lpi4a/MAINTAINERS > > > > create mode 100644 board/thead/th1520_lpi4a/Makefile > > > > create mode 100644 board/thead/th1520_lpi4a/board.c > > > > create mode 100644 include/configs/th1520_lpi4a.h > > > > > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > > > index f6ed05906a..419b6171a9 100644 > > > > --- a/arch/riscv/Kconfig > > > > +++ b/arch/riscv/Kconfig > > > > @@ -27,6 +27,10 @@ config TARGET_SIFIVE_UNMATCHED > > > > config TARGET_STARFIVE_VISIONFIVE2 > > > > bool "Support StarFive VisionFive2 Board" > > > > > > > > +config TARGET_TH1520_LPI4A > > > > + bool "Support Sipeed's TH1520 Lichee PI 4A Board" > > > > + select SYS_CACHE_SHIFT_6 > > > > + > > > > config TARGET_SIPEED_MAIX > > > > bool "Support Sipeed Maix Board" > > > > select SYS_CACHE_SHIFT_6 > > > > @@ -66,6 +70,7 @@ source "board/emulation/qemu-riscv/Kconfig" > > > > source "board/microchip/mpfs_icicle/Kconfig" > > > > source "board/sifive/unleashed/Kconfig" > > > > source "board/sifive/unmatched/Kconfig" > > > > +source "board/thead/th1520_lpi4a/Kconfig" > > > > source "board/openpiton/riscv64/Kconfig" > > > > source "board/sipeed/maix/Kconfig" > > > > source "board/starfive/visionfive2/Kconfig" > > > > diff --git a/board/thead/th1520_lpi4a/Kconfig > > > > b/board/thead/th1520_lpi4a/Kconfig > > > > new file mode 100644 > > > > index 0000000000..622246127c > > > > --- /dev/null > > > > +++ b/board/thead/th1520_lpi4a/Kconfig > > > > @@ -0,0 +1,42 @@ > > > > +if TARGET_TH1520_LPI4A > > > > + > > > > +config ARCH_THEAD > > > > + bool > > > > + default y > > > > + > > > > +config SYS_BOARD > > > > + default "th1520_lpi4a" > > for the board, I'm not sure whether people will prefer to keep the > > 'th1520_' prefix, > > otherwise we could make it shorter, leave only 'lpi4a'? thoughts? > > > > > > + > > > > +config SYS_VENDOR > > > > + default "thread" > > ~~~~~~~ notice, in my original patch, it's 'thead' > > > default "T-HEAD" > > No, here should be 'thead', since the CONFIG_SYS_VENDOR will form > > board/${CONFIG_SYS_VENDOR}, please consult arch/Kconfig for reference. > > > > I personally would prefer 't-head' which probably cause less confusion.. > > but since kernel use 'thead'[1], so I just follow it to keep them aligned. > > > > But you have a typo here :) do you mean 'thread'? It's 'thead' actually in my original patch, so no typo.. I was already trying to clarify this.
It's probably a grammar correction when Guo reply the email https://lore.kernel.org/all/[email protected]/ > > > [1] in kernel, the dts path consist of 'thead', e.g. > > arch/riscv/boot/dts/thead/ > > > > Regards, > Bin -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55
