On Mon, Feb 5, 2024 at 4:53 AM Jonas Karlman <jo...@kwiboo.se> wrote: > > Testing has shown that writing to eMMC using DDR52 mode does not seem to > work on RK356x and RK3588 boards. > > A simple test of writing a single block to e.g. sector 0x4000 fails: > > # Rescan using DDR52 mode > => mmc rescan 4 > > # Write a single block to sector 0x4000 fails with ERROR > => mmc write 20000000 4000 1 > > With the MMC_SPEED_MODE_SET Kconfig option enabled. > > Fix this by removing the mmc-ddr-1_8v prop from sdhci nodes in affected > board u-boot.dtsi files. > > Signed-off-by: Jonas Karlman <jo...@kwiboo.se>
Reviewed-by: Weizhao Ouyang <o451686...@gmail.com> BR, Weizhao > --- > Changes in v2: > - Update commit message > > Link to v1: https://patchwork.ozlabs.org/patch/1891695/ > --- > arch/arm/dts/rk3566-quartz64-a-u-boot.dtsi | 1 - > arch/arm/dts/rk3566-quartz64-b-u-boot.dtsi | 1 - > arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 1 - > arch/arm/dts/rk3566-soquartz-u-boot.dtsi | 1 - > arch/arm/dts/rk3568-lubancat-2-u-boot.dtsi | 1 - > arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi | 1 - > arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi | 1 - > arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi | 1 - > arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 1 - > arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 1 - > arch/arm/dts/rk3588-turing-rk1-u-boot.dtsi | 1 - > arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi | 1 - > 12 files changed, 12 deletions(-) > > diff --git a/arch/arm/dts/rk3566-quartz64-a-u-boot.dtsi > b/arch/arm/dts/rk3566-quartz64-a-u-boot.dtsi > index 11976fd3a6e0..930d660868bb 100644 > --- a/arch/arm/dts/rk3566-quartz64-a-u-boot.dtsi > +++ b/arch/arm/dts/rk3566-quartz64-a-u-boot.dtsi > @@ -8,7 +8,6 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > pinctrl-names = "default"; > pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>; > }; > diff --git a/arch/arm/dts/rk3566-quartz64-b-u-boot.dtsi > b/arch/arm/dts/rk3566-quartz64-b-u-boot.dtsi > index 8de9d1535efb..c235b4357f7d 100644 > --- a/arch/arm/dts/rk3566-quartz64-b-u-boot.dtsi > +++ b/arch/arm/dts/rk3566-quartz64-b-u-boot.dtsi > @@ -4,7 +4,6 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > pinctrl-names = "default"; > pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>; > }; > diff --git a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi > b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi > index 158f652cb3b1..e0e501deccfe 100644 > --- a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi > +++ b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi > @@ -7,5 +7,4 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > }; > diff --git a/arch/arm/dts/rk3566-soquartz-u-boot.dtsi > b/arch/arm/dts/rk3566-soquartz-u-boot.dtsi > index f65f4067f3e9..5e46a2422d60 100644 > --- a/arch/arm/dts/rk3566-soquartz-u-boot.dtsi > +++ b/arch/arm/dts/rk3566-soquartz-u-boot.dtsi > @@ -4,7 +4,6 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > pinctrl-names = "default"; > pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>; > }; > diff --git a/arch/arm/dts/rk3568-lubancat-2-u-boot.dtsi > b/arch/arm/dts/rk3568-lubancat-2-u-boot.dtsi > index a44ac35bdacd..1597473017ed 100644 > --- a/arch/arm/dts/rk3568-lubancat-2-u-boot.dtsi > +++ b/arch/arm/dts/rk3568-lubancat-2-u-boot.dtsi > @@ -8,7 +8,6 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > mmc-hs400-1_8v; > mmc-hs400-enhanced-strobe; > pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>; > diff --git a/arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi > b/arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi > index 62f572c4cf9f..64c43374c042 100644 > --- a/arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi > +++ b/arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi > @@ -14,7 +14,6 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > mmc-hs200-1_8v; > mmc-hs400-1_8v; > mmc-hs400-enhanced-strobe; > diff --git a/arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi > b/arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi > index ecba91aa30f5..1fc71faa9e07 100644 > --- a/arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi > +++ b/arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi > @@ -8,7 +8,6 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > mmc-hs200-1_8v; > mmc-hs400-1_8v; > mmc-hs400-enhanced-strobe; > diff --git a/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi > b/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi > index caf524443079..74755a44eaee 100644 > --- a/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi > +++ b/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi > @@ -16,7 +16,6 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > mmc-hs200-1_8v; > mmc-hs400-1_8v; > mmc-hs400-enhanced-strobe; > diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi > b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi > index 46ebb77283f1..5b823fcca5fb 100644 > --- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi > +++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi > @@ -20,7 +20,6 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > mmc-hs200-1_8v; > mmc-hs400-1_8v; > mmc-hs400-enhanced-strobe; > diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > index e99e60185ebe..9ee9dd051e32 100644 > --- a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > +++ b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > @@ -31,7 +31,6 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > mmc-hs200-1_8v; > }; > > diff --git a/arch/arm/dts/rk3588-turing-rk1-u-boot.dtsi > b/arch/arm/dts/rk3588-turing-rk1-u-boot.dtsi > index 471508a9ed74..ca2a684f3541 100644 > --- a/arch/arm/dts/rk3588-turing-rk1-u-boot.dtsi > +++ b/arch/arm/dts/rk3588-turing-rk1-u-boot.dtsi > @@ -8,7 +8,6 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > mmc-hs200-1_8v; > }; > > diff --git a/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi > b/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi > index 9a6a353088df..efba0c359ba5 100644 > --- a/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi > +++ b/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi > @@ -7,6 +7,5 @@ > > &sdhci { > cap-mmc-highspeed; > - mmc-ddr-1_8v; > mmc-hs200-1_8v; > }; > -- > 2.43.0 >