On 10/04/2024 12:56, Sumit Garg wrote:
Hi Caleb,

On Tue, 9 Apr 2024 at 23:33, Caleb Connolly <[email protected]> wrote:

Remove the reference to the xo clock which is on the unsupported rpmhcc
clock controller. It isn't needed for MMC functionality.

Can it rather be handled via a NOP clock driver for rpmhcc? I suppose
this kind of DT modifications would push us away from upstream DT
compatibility.

Yes, I plan to switch to that eventually with these patches (which I'll try and send soon). I just didn't want to leave this broken in the meantime.

https://git.codelinaro.org/linaro/qcomlt/u-boot/-/commit/85f5fc736777c9a0807c2187a613428f7cd305df

https://git.codelinaro.org/linaro/qcomlt/u-boot/-/commit/973279605dd19e823569d6f92962de9157d33a30

-Sumit


Signed-off-by: Caleb Connolly <[email protected]>
---
  arch/arm/dts/sdm845-db845c-u-boot.dtsi | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/arch/arm/dts/sdm845-db845c-u-boot.dtsi 
b/arch/arm/dts/sdm845-db845c-u-boot.dtsi
index 906f9faa5451..9e4533e603c5 100644
--- a/arch/arm/dts/sdm845-db845c-u-boot.dtsi
+++ b/arch/arm/dts/sdm845-db845c-u-boot.dtsi
@@ -6,4 +6,11 @@
   */
  &pcie0_3p3v_dual {
         regulator-always-on;
  };
+
+&sdhc_2 {
+       /* Remove the unsupported rpmhcc xo clock reference */
+       clocks = <&gcc GCC_SDCC2_AHB_CLK>,
+                <&gcc GCC_SDCC2_APPS_CLK>;
+       clock-names = "iface", "core";
+};

--
2.44.0


--
// Caleb (they/them)

Reply via email to