Hi,

On Wed Oct 2, 2024 at 8:08 PM CEST, Peter Robinson wrote:
> The primary upstream URL for tf-a has moved, in some cases
> things like tags are not always pushed to the old URL so
> update the URLs to the primary upstream project URL.
>
> Signed-off-by: Peter Robinson <[email protected]>
> ---
>  board/rockchip/evb_rk3399/README       | 2 +-
>  board/sunxi/README.sunxi64             | 2 +-
>  common/spl/Kconfig                     | 2 +-
>  doc/README.rockchip                    | 2 +-
>  doc/README.uniphier                    | 2 +-
>  doc/board/armltd/juno.rst              | 2 +-
>  doc/board/bsh/imx8mn_bsh_smm_s2.rst    | 2 +-
>  doc/board/hisilicon/hikey.rst          | 4 ++--
>  doc/board/hisilicon/hikey960.rst       | 4 ++--
>  doc/board/kontron/pitx-imx8m.rst       | 2 +-
>  doc/board/rockchip/rockchip.rst        | 2 +-
>  doc/board/variscite/imx8mn_var_som.rst | 2 +-
>  include/atf_common.h                   | 2 +-
>  tools/binman/entries.rst               | 2 +-
>  tools/binman/etype/atf_bl31.py         | 2 +-
>  tools/binman/fip_util.py               | 4 ++--
>  16 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/board/rockchip/evb_rk3399/README 
> b/board/rockchip/evb_rk3399/README
> index c6f58203ebe..c7caf1756d6 100644
> --- a/board/rockchip/evb_rk3399/README
> +++ b/board/rockchip/evb_rk3399/README
> @@ -31,7 +31,7 @@ Get the Source and prebuild binary
>  
>    > mkdir ~/evb_rk3399
>    > cd ~/evb_rk3399
> -  > git clone https://github.com/ARM-software/arm-trusted-firmware.git
> +  > git clone https://github.com/TrustedFirmware-A/trusted-firmware-a.git
>    > git clone https://github.com/rockchip-linux/rkbin.git
>    > git clone https://github.com/rockchip-linux/rkdeveloptool.git
>  

I already mentioned this on IRC, but figured that this may be a better
way to communicate it.

This patch seems incomplete as the git repo's name has changed, but not
all the instructions which reference it.

So for example in this patch, this is the code that follows:

> Compile ATF
> ===========
> 
>   > cd arm-trusted-firmware
>   > make realclean

That ``cd`` command doesn't work as it should be ``cd trusted-firmware-a``.

This is just an example as this issue is present in more files (which
were modified by this patch).

Optionally you could consider if in f.e. ``tools/binman/fip_util.py`` 
``srcdir (str): 'arm-trusted-firmware' source directory``

should be updated to trusted-firmware-a. Not an error and probably
everyone understands what is meant, but for consistency it could be
beneficial if they're all updated.

> diff --git a/doc/README.rockchip b/doc/README.rockchip
> index 84caff8a24d..5fcbbd1d990 100644
> --- a/doc/README.rockchip
> +++ b/doc/README.rockchip
> @@ -73,7 +73,7 @@ Building
>  
>     - Compile ATF
>  
> -     => git clone https://github.com/ARM-software/arm-trusted-firmware.git
> +     => git clone https://github.com/TrustedFirmware-A/trusted-firmware-a.git
>       => cd arm-trusted-firmware
>  
>       (export cross compiler path for Cortex-M0 MCU likely arm-none-eabi-)

This is one of those others that should be updated (and is directly
visible on
https://source.denx.de/u-boot/u-boot/-/commit/0ec0207fe07356bddb10db717e21c261bebfb989

Cheers,
  Diederik

Attachment: signature.asc
Description: PGP signature

Reply via email to