Am 08.11.24 um 13:59 schrieb Yannic Moog:
On Thu, 2024-11-07 at 10:07 +0100, Wadim Egorov wrote:


Am 07.11.24 um 09:23 schrieb Yannic Moog:
Add documentation for the phyBOARD-Pollux i.MX 8M Plus on OP-TEE
integration.
Also add missing '-' to TF-A build instruction while at it.


Would it make sense to move these instructions into a more general
section, so they could be reused by other imx based boards as well?

I have not put much thought into it. At first glance though, when reading the 
documentation for a
board I don't want to be redirected to other pages. So using an include comes 
to mind. Is that what
you had in mind as well?

Yes, I was thinking about using includes to reduce doc duplication.


Seems you missed to update imx8mm-phygate-tauri-l.rst

Should be in the (next) patch for the imx8mm, as Tauri is based on 
phycore-imx8mm. Let me know if
you meant something else.

Ah! I missed that you change both files in the next patch.


Yannic



Signed-off-by: Yannic Moog <[email protected]>
---
   doc/board/phytec/phycore-imx8mp.rst | 26 +++++++++++++++++++++++++-
   1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/doc/board/phytec/phycore-imx8mp.rst 
b/doc/board/phytec/phycore-imx8mp.rst
index fda751aeffb..4bcfa9f39ca 100644
--- a/doc/board/phytec/phycore-imx8mp.rst
+++ b/doc/board/phytec/phycore-imx8mp.rst
@@ -9,6 +9,7 @@ Quick Start
   -----------
  - Build the ARM Trusted firmware binary
+- Build the OP-TEE binary (optional)
   - Get ddr firmware
   - Build U-Boot
   - Boot
@@ -20,10 +21,32 @@ Build the ARM Trusted firmware binary
     $ git clone https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git
      $ cd trusted-firmware-a
-   $ export CROSS_COMPILE=aarch64-linux-gnu
+   $ export CROSS_COMPILE=aarch64-linux-gnu-
      $ export IMX_BOOT_UART_BASE=0x30860000
+   $ # with optee
+   $ make PLAT=imx8mp SPD=opteed bl31
+   $ # without optee
      $ make PLAT=imx8mp bl31
+Build the OP-TEE binary (optional)
+----------------------------------
+
+.. code-block:: bash
+
+   $ git clone https://github.com/OP-TEE/optee_os.git
+   $ cd optee_os
+   $ make CFG_ARM64_core=y \
+     CFG_TEE_BENCHMARK=n \
+     CROSS_COMPILE=aarch64-linux-gnu- \
+     CROSS_COMPILE_core=aarch64-linux-gnu- \
+     CROSS_COMPILE_ta_arm32=arm-linux-gnueabihf- \
+     CROSS_COMPILE_ta_arm64=aarch64-linux-gnu- \
+     O=out/arm \
+     PLATFORM=imx-mx8mpevk \
+     CFG_TZDRAM_START=0x56000000 \
+     CFG_DDR_SIZE=0x80000000 \
+     CFG_UART_BASE=UART1_BASE
+
   Get the ddr firmware
   --------------------
@@ -42,6 +65,7 @@ Copy binaries
   .. code-block:: bash
     $ cp <TF-A dir>/build/imx8mp/release/bl31.bin .
+   $ cp <OP-TEE dir>/out/arm/core/tee-raw.bin tee.bin
      $ cp firmware-imx-8.19/firmware/ddr/synopsys/lpddr4*.bin .
  Build U-Boot




Reply via email to