On 07.01.25 19:06, Duje Mihanović wrote:
On Tuesday 7 January 2025 12:30:40 Central European Standard Time Stefan Roese
wrote:
On 31.12.24 17:49, Duje Mihanović wrote:
{ .compatible = "ingenic,jz4780-uart", .data = PORT_JZ4780 },
{ .compatible = "nvidia,tegra20-uart", .data = PORT_NS16550 },
{ .compatible = "snps,dw-apb-uart", .data = PORT_NS16550 },
+ { .compatible = "intel,xscale-uart", .data = PORT_NS16550 },
Looking at the Linux 8250 of_device_id struct I see this entry:
{ .compatible = "mrvl,mmp-uart",
.data = (void *)PORT_XSCALE, },
Wouldn't it make more sense to use this compatible property instead?
I was going by the logic that intel,xscale-uart is more generic. They use
identical platform data, so it would be no problem at all.
Please check which compatible property is present in the Linux upstream
dts/dtsi file for the Marvel SoC and use this one. This will make
sync'ing with upstream dts easier.
Thanks,
Stefan
