Hi Quentin, On 7/15/2025 11:19 AM, Quentin Schulz wrote: > Hi Jonas, > > On 7/14/25 1:33 AM, Jonas Karlman wrote: >> Remove the cru assigned-clocks override now that SCLK_GPU is supported >> by the clock driver. >> >> Signed-off-by: Jonas Karlman <jo...@kwiboo.se> > > Reviewed-by: Quentin Schulz <quentin.sch...@cherry.de> > > And this seems like we can remove > > /delete-property/ assigned-clocks; > /delete-property/ assigned-clock-rates; > > from cru and pmucru from arch/arm/dts/px30-u-boot.dtsi?
Yes, I think so too, but I do not have any PX30 device only a single RK3326 device, so I try to be very cautious when it comes to PX30. > > And... maybe we can eventually make > arch/arm/dts/rk3326-odroid-go2-u-boot.dtsi include > arch/arm/dts/px30-u-boot.dtsi to avoid duplication and match what the > upstream DT does (including rk3326.dtsi which includes px30.dtsi and > deletes VOPL)? Yes, I think so too, in a future series, in this series I tried to be very cautious to ensure that only odroid-go2 was affected. This series mostly started out with me wanting to test your checkboard() patch and then it evolved into something more :-). Regards, Jonas > > Cheers, > Quentin
