On Mon, Aug 11, 2025 at 10:50:17AM +0200, Philip Oberfichtner wrote: > The idea of treating a size limit of zero as unlimited has been common > practice in mainline U-Boot since 2019, where CONFIG_SPL_SIZE_LIMIT has > been introduced. The same logic has later been applied to TPL and VPL > size limits. > > If we want to consistently stick to the HAS_*_SIZE_LIMIT approach, we'd > have to introduce four extra Kconfig options alongside > HAS_BOARD_SIZE_LIMIT: > > CONFIG_HAS_UBOOT_WITH_SPL_SIZE_LIMIT > CONFIG_HAS_SPL_SIZE_LIMIT > CONFIG_HAS_TPL_SIZE_LIMIT > CONFIG_HAS_VPL_SIZE_LIMIT > > > Furthermore, the extra lines of code in the toplevel Makefile, which > could otherwise be removed: > > ifneq ($(CONFIG_BOARD_SIZE_LIMIT),) > BOARD_SIZE_CHECK= @ $(call size_check,$@,$(CONFIG_BOARD_SIZE_LIMIT)) > else > BOARD_SIZE_CHECK = > endif > > ifneq ($(CONFIG_HAS_UBOOT_WITH_SPL_SIZE_LIMIT),0x0) > UBOOT_WITH_SPL_SIZE_CHECK = @$(call > size_check,$@,$(CONFIG_UBOOT_WITH_SPL_SIZE_LIMIT) > else > UBOOT_WITH_SPL_SIZE_CHECK = > endif > > ifneq ($(CONFIG_SPL_SIZE_LIMIT),0x0) > SPL_SIZE_CHECK = @$(call size_check,$@,$$(tools/spl_size_limit)) > else > SPL_SIZE_CHECK = > endif > > ifneq ($(CONFIG_TPL_SIZE_LIMIT),0x0) > TPL_SIZE_CHECK = @$(call size_check,$@,$(CONFIG_TPL_SIZE_LIMIT)) > else > TPL_SIZE_CHECK = > endif > > ifneq ($(CONFIG_VPL_SIZE_LIMIT),0x0) > VPL_SIZE_CHECK = @$(call size_check,$@,$(CONFIG_VPL_SIZE_LIMIT)) > else > VPL_SIZE_CHECK = > endif > > > Is it really worth adding this much of extra code?
Ping @Marek: So are you in favor of this surplus of code?
