Thanks, Marek,
Can you please show me the preferred format?
This was the original format,
{
INFO("gd25q32", 0xc84016, 0, 64 * 1024, 64,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
},
This one looks cleaner.
{INFO("gd25b256", 0xc84019, 0, 64 * 1024, 512, SECT_4K |
SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK |
SPI_NOR_4B_OPCODES) },
Regards,
Victor
________________________________
From: Marek Vasut <[email protected]>
Sent: Tuesday, October 28, 2025 18:07
To: Vlim <[email protected]>; [email protected] <[email protected]>
Cc: Jagan Teki <[email protected]>; Takahiro Kuwano
<[email protected]>; Tom Rini <[email protected]>; Tudor Ambarus
<[email protected]>; Venkatesh Yadav Abbarapu
<[email protected]>; Vignesh R <[email protected]>; havish.mutya
<[email protected]>
Subject: Re: [PATCH] mtd: spi-nor-ids: Reformat the table
[You don't often get email from [email protected]. Learn why this is
important at https://aka.ms/LearnAboutSenderIdentification ]
此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
This is an external email, beware of phishing emails. Please pay close
attention to whether the email contains sensitive information
On 10/28/25 9:33 PM, Vlim wrote:
> Hi, Marek,
Hello Vlim,
> 1.
> reformat the table to follow this format.
>
> {
> INFO("gd25q32", 0xc84016, 0, 64 * 1024, 64,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> },
Why this way ? Does it bring any improvement, aside from being less
concise ?
> 1.
> Re-arrange the order of the table based on the ID, so that I can group the
> part #s by product family.
Sure. I'll just wait for the maintainer and whichever patch they pick
first, the other will be rebased and resent.
> 2.
> I have a few more part numbers to add to the table, can I add them with this
> update?
Sure.
> 3.
> Do I submit as a new patch?
Yes, but please, let's wait for maintainer input first.
--
Best regards,
Marek Vasut
