Re: [PATCH] mtd: spi-nor-ids: Reformat the table

[Vlim]

Hi, Marek,

I am ready to add a few new part numbers.

Do you have a preferred format yet for the table?

I can upload the patch for the new part numbers and address the format in the 
future.

Regards,

Victor

________________________________
From: Vlim <v...@gigadevice.com>
Sent: Tuesday, October 28, 2025 18:53
To: Marek Vasut <marek.va...@mailbox.org>; u-boot@lists.denx.de 
<u-boot@lists.denx.de>
Cc: Jagan Teki <ja...@amarulasolutions.com>; Takahiro Kuwano 
<takahiro.kuw...@infineon.com>; Tom Rini <tr...@konsulko.com>; Tudor Ambarus 
<tudor.amba...@linaro.org>; Venkatesh Yadav Abbarapu 
<venkatesh.abbar...@amd.com>; Vignesh R <vigne...@ti.com>; havish.mutya 
<havish.mu...@amd.com>
Subject: Re: [PATCH] mtd: spi-nor-ids: Reformat the table

Thanks, Marek,

Can you please show me the preferred format?

This was the original format,

 {
             INFO("gd25q32", 0xc84016, 0, 64 * 1024,  64,
                   SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
                   SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
       },


This one looks cleaner.

      {INFO("gd25b256", 0xc84019, 0, 64 * 1024, 512,  SECT_4K |
      SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | 
SPI_NOR_4B_OPCODES)      },

Regards,

Victor

________________________________
From: Marek Vasut <marek.va...@mailbox.org>
Sent: Tuesday, October 28, 2025 18:07
To: Vlim <v...@gigadevice.com>; u-boot@lists.denx.de <u-boot@lists.denx.de>
Cc: Jagan Teki <ja...@amarulasolutions.com>; Takahiro Kuwano 
<takahiro.kuw...@infineon.com>; Tom Rini <tr...@konsulko.com>; Tudor Ambarus 
<tudor.amba...@linaro.org>; Venkatesh Yadav Abbarapu 
<venkatesh.abbar...@amd.com>; Vignesh R <vigne...@ti.com>; havish.mutya 
<havish.mu...@amd.com>
Subject: Re: [PATCH] mtd: spi-nor-ids: Reformat the table

[You don't often get email from marek.va...@mailbox.org. Learn why this is 
important at https://aka.ms/LearnAboutSenderIdentification ]

此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
This is an external email, beware of phishing emails. Please pay close 
attention to whether the email contains sensitive information

On 10/28/25 9:33 PM, Vlim wrote:
> Hi, Marek,

Hello Vlim,

>    1.
> reformat the table to follow this format.
>
>       {
>             INFO("gd25q32", 0xc84016, 0, 64 * 1024,  64,
>                   SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>                   SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>       },

Why this way ? Does it bring any improvement, aside from being less
concise ?

>    1.
> Re-arrange the order of the table based on the ID, so that I can group the 
> part #s by product family.

Sure. I'll just wait for the maintainer and whichever patch they pick
first, the other will be rebased and resent.

>    2.
> I have a few more part numbers to add to the table, can I add them with this 
> update?

Sure.

>    3.
> Do I submit as a new patch?

Yes, but please, let's wait for maintainer input first.

--
Best regards,
Marek Vasut