On 12/9/25 16:32, Ralph Siemsen wrote: > Hi Sean, > > On Mon, Dec 8, 2025 at 5:55 PM Sean Anderson <[email protected]> wrote: >> > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig >> > index 2afb15fff1e..94054ba39b0 100644 >> > --- a/drivers/spi/Kconfig >> > +++ b/drivers/spi/Kconfig >> > @@ -223,6 +223,14 @@ config DESIGNWARE_SPI >> > access the SPI NOR flash on platforms embedding this Designware >> > IP core. >> > >> > +config SPL_DESIGNWARE_SPI >> > + bool "Designware SPI driver in SPL" >> > + depends on SPL >> > + default y >> > + help >> > + Enable the Designware SPI driver during SPL. >> > + See the help of DESIGNWARE_SPI for details. >> > + >> >> In addition to Tom's comment this should probably be moved out of the >> SPI/DM_SPI if/endif and made to depend on SPL_DM_SPI. > > Ack for Tom's change, but I am puzzled by your request to move it out > of the existing ifdev. I would think that we'd want the two options to > appear next to each other when running 'menuconfig'.
That would be good, but each `if` adds a dependency on the condition, and this is incorrect for SPL. > While I admit that adding SPL- and perhaps TPL- prefixed symbols is a > bit messy, it seems to be how it has been done elsewhere. For example > drivers/clk/Kconfig has quite a few such cases. And if you notice, in that file each config explicitly specifies whether it depends on CLK/CLK_CCF/SPL_CLK/SPL_CLK_CCF rather than using an if. If you don't like the configs living too far apart, you can move DESIGNWARE_SPI out of the if as well and explicitly add a dependency on DM_SPI. --Sean [CES 2026, SECO]<https://exhibitors.ces.tech/8_0/exhibitor/exhibitor-details.cfm?exhid=001Pp000010EbaOIAS>
