On Tue, Feb 24, 2026 at 07:25:51AM -0700, Simon Glass wrote:
> This function is not present on x86, but there is an x86-specific
> version which is never called. This is a bug, meaning that APs are not
> parked before booting.
>
> The original weak function was added in 2012 by:
> commit f30fc4de4160 ("x86: Add a default implementation for
> cleanup_before_linux()")
>
> At later change made use of the weak function but was actually dead
> code. The Fixes tag reflects that.
>
> Add cleanup_before_linux(), making it call x86_cleanup_before_linux()
>
> Fixes: 99a573fb326f ("x86: mp: Park CPUs before running the OS")
> Signed-off-by: Simon Glass <[email protected]>We're at over 5 years since 99a573fb326f and over a decade since f30fc4de4160 and I don't think it was ever actually called. We should just be dropping this, not suddenly calling it. -- Tom
signature.asc
Description: PGP signature
