Re: [PATCH v2 7/9] riscv: Drop board_quiesce_devices()

[Tom Rini]

On Tue, Feb 24, 2026 at 07:25:49AM -0700, Simon Glass wrote:

> This is not used on RISC-V so drop it.
> 
> Signed-off-by: Simon Glass <simon.gl...@canonical.com>
> ---
> 
> Changes in v2:
> - Drop the call to udc_disconnect()
> 
>  arch/riscv/include/asm/u-boot-riscv.h | 1 -
>  arch/riscv/lib/bootm.c                | 6 ------
>  2 files changed, 7 deletions(-)
> 
> diff --git a/arch/riscv/include/asm/u-boot-riscv.h 
> b/arch/riscv/include/asm/u-boot-riscv.h
> index 543a1688db8..3a8fdb57136 100644
> --- a/arch/riscv/include/asm/u-boot-riscv.h
> +++ b/arch/riscv/include/asm/u-boot-riscv.h
> @@ -16,7 +16,6 @@ int cleanup_before_linux(void);
>  
>  /* board/.../... */
>  int board_init(void);
> -void board_quiesce_devices(void);
>  int riscv_board_reserved_mem_fixup(void *fdt);
>  int riscv_fdt_copy_resv_mem_node(const void *src_fdt, void *dest_fdt);
>  
> diff --git a/arch/riscv/lib/bootm.c b/arch/riscv/lib/bootm.c
> index 9544907ab1e..c6a008a4559 100644
> --- a/arch/riscv/lib/bootm.c
> +++ b/arch/riscv/lib/bootm.c
> @@ -25,10 +25,6 @@
>  
>  DECLARE_GLOBAL_DATA_PTR;
>  
> -__weak void board_quiesce_devices(void)
> -{
> -}
> -
>  /**
>   * announce_and_cleanup() - Print message and prepare for kernel boot
>   *
> @@ -46,8 +42,6 @@ static void announce_and_cleanup(int fake)
>       bootstage_report();
>  #endif
>  
> -     board_quiesce_devices();
> -
>       /*
>        * Call remove function of all devices with a removal flag set.
>        * This may be useful for last-stage operations, like cancelling

This should end up in bootm_final, as the generic hook for things which
don't fit in to the DM model.

-- 
Tom

signature.asc
Description: PGP signature