On 5/9/26 6:11 AM, Mikhail Kshevetskiy wrote:
> This patch adds U-Boot pin controller and gpio driver for Airoha AN7581 SoC.
> 
> Signed-off-by: Mikhail Kshevetskiy <[email protected]>
> ---
>  drivers/pinctrl/airoha/Kconfig          |    5 +
>  drivers/pinctrl/airoha/Makefile         |    2 +
>  drivers/pinctrl/airoha/pinctrl-an7581.c | 1076 +++++++++++++++++++++++
>  3 files changed, 1083 insertions(+)
>  create mode 100644 drivers/pinctrl/airoha/pinctrl-an7581.c
> 
> diff --git a/drivers/pinctrl/airoha/Kconfig b/drivers/pinctrl/airoha/Kconfig
> index eb87afbb374..986d23c2e3d 100644
> --- a/drivers/pinctrl/airoha/Kconfig
> +++ b/drivers/pinctrl/airoha/Kconfig
> @@ -9,3 +9,8 @@ config PINCTRL_AIROHA
>       select REGMAP
>       select SYSCON
>       bool
> +
> +config PINCTRL_AIROHA_AN7581
> +     tristate "AN7581 pin controller and gpio driver"
> +     depends on TARGET_AN7581
> +     select PINCTRL_AIROHA
> diff --git a/drivers/pinctrl/airoha/Makefile b/drivers/pinctrl/airoha/Makefile
> index a25b744dd7a..909bd9a04d9 100644
> --- a/drivers/pinctrl/airoha/Makefile
> +++ b/drivers/pinctrl/airoha/Makefile
> @@ -1,3 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
>  
>  obj-$(CONFIG_PINCTRL_AIROHA)         += pinctrl-airoha.o
> +
> +obj-$(CONFIG_PINCTRL_AIROHA_AN7581)  += pinctrl-an7581.o
> diff --git a/drivers/pinctrl/airoha/pinctrl-an7581.c 
> b/drivers/pinctrl/airoha/pinctrl-an7581.c
> new file mode 100644
> index 00000000000..606e042b069
> --- /dev/null
> +++ b/drivers/pinctrl/airoha/pinctrl-an7581.c
> @@ -0,0 +1,1076 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Author: Lorenzo Bianconi <[email protected]>
> + * Author: Benjamin Larsson <[email protected]>
> + * Author: Markus Gothe <[email protected]>
> + */
> +#include "airoha-common.h"
> +

It still throws me off that the en7581_ prefix is not the same
as the file name/driver name/config symbol name. If en7581
is preferred, can we change everything (an7581) to match?

> +static const int en7581_pon_pins[] = { 49, 50, 51, 52, 53, 54 };
> +static const int en7581_pon_tod_1pps_pins[] = { 46 };
> +static const int en7581_gsw_tod_1pps_pins[] = { 46 };
> +static const int en7581_sipo_pins[] = { 16, 17 };
> +static const int en7581_sipo_rclk_pins[] = { 16, 17, 43 };
> +static const int en7581_mdio_pins[] = { 14, 15 };
> +static const int en7581_uart2_pins[] = { 48, 55 };
> +static const int en7581_uart2_cts_rts_pins[] = { 46, 47 };
> +static const int en7581_hsuart_pins[] = { 28, 29 };

Reply via email to