On 5/13/26 8:56 AM, Tom Rini wrote: > On Wed, May 13, 2026 at 01:30:47PM +0200, Benjamin Larsson wrote: >> Hi. >> >> On 13/05/2026 01:42, David Lechner wrote: >>> On 5/9/26 6:11 AM, Mikhail Kshevetskiy wrote: >>>> This patch adds U-Boot pin controller and gpio driver for Airoha AN7581 >>>> SoC. >>>> >>>> Signed-off-by: Mikhail Kshevetskiy <[email protected]> >>>> --- >>>> drivers/pinctrl/airoha/Kconfig | 5 + >>>> drivers/pinctrl/airoha/Makefile | 2 + >>>> drivers/pinctrl/airoha/pinctrl-an7581.c | 1076 +++++++++++++++++++++++ >>>> 3 files changed, 1083 insertions(+) >>>> create mode 100644 drivers/pinctrl/airoha/pinctrl-an7581.c >>>> >>>> diff --git a/drivers/pinctrl/airoha/Kconfig >>>> b/drivers/pinctrl/airoha/Kconfig >>>> index eb87afbb374..986d23c2e3d 100644 >>>> --- a/drivers/pinctrl/airoha/Kconfig >>>> +++ b/drivers/pinctrl/airoha/Kconfig >>>> @@ -9,3 +9,8 @@ config PINCTRL_AIROHA >>>> select REGMAP >>>> select SYSCON >>>> bool >>>> + >>>> +config PINCTRL_AIROHA_AN7581 >>>> + tristate "AN7581 pin controller and gpio driver" >>>> + depends on TARGET_AN7581 >>>> + select PINCTRL_AIROHA >>>> diff --git a/drivers/pinctrl/airoha/Makefile >>>> b/drivers/pinctrl/airoha/Makefile >>>> index a25b744dd7a..909bd9a04d9 100644 >>>> --- a/drivers/pinctrl/airoha/Makefile >>>> +++ b/drivers/pinctrl/airoha/Makefile >>>> @@ -1,3 +1,5 @@ >>>> # SPDX-License-Identifier: GPL-2.0 >>>> obj-$(CONFIG_PINCTRL_AIROHA) += pinctrl-airoha.o >>>> + >>>> +obj-$(CONFIG_PINCTRL_AIROHA_AN7581) += pinctrl-an7581.o >>>> diff --git a/drivers/pinctrl/airoha/pinctrl-an7581.c >>>> b/drivers/pinctrl/airoha/pinctrl-an7581.c >>>> new file mode 100644 >>>> index 00000000000..606e042b069 >>>> --- /dev/null >>>> +++ b/drivers/pinctrl/airoha/pinctrl-an7581.c >>>> @@ -0,0 +1,1076 @@ >>>> +// SPDX-License-Identifier: GPL-2.0-only >>>> +/* >>>> + * Author: Lorenzo Bianconi <[email protected]> >>>> + * Author: Benjamin Larsson <[email protected]> >>>> + * Author: Markus Gothe <[email protected]> >>>> + */ >>>> +#include "airoha-common.h" >>>> + >>> It still throws me off that the en7581_ prefix is not the same >>> as the file name/driver name/config symbol name. If en7581 >>> is preferred, can we change everything (an7581) to match? >> >> The physical chip is marked AN7581 but I have seen some old EN7581 uses in >> Airoha(Econet) material. I'm not really happy with this situation but for >> some reason the en7581 name has been pushed for this SoC in mainline kernel >> code. >> >> Ideally linux and uboot should use the same naming but I'm fine with >> whatever gets code landing upstream. > > I agree consistent naming with the linux kernel is important here. >
To be clear, I'm asking for s/an7581/en7581/ s/AN7581/EN7581/ in this patch (which matches Linux). Right now we have a mix of both. Mentioning AN7581 in the Kconfig help and in a comment at the top of the driver file is fine too so that it can be found by both names.
