Hi Zixun, Thank you for the patch.
On Fri, May 15, 2026 at 12:05, Zixun LI <[email protected]> wrote: > Endpoints should not be disabled on bus reset inside UDC driver, > otherwise a race condition will happen between gadget driver. Gadget > driver will free the requests and disable endpoints in disconnect ops. > > Also remove outdated comment about it in usba_ep_disable(). > > Fixes: 59310d1ecb9f ("usb: gadget: introduce 'enabled' flag in struct usb_ep") > > Signed-off-by: Zixun LI <[email protected]> Reviewed-by: Mattijs Korpershoek <[email protected]> Note: there should not be an empty newline between the fixes and the signed-off. It should be: Fixes: 59310d1ecb9f ("usb: gadget: introduce 'enabled' flag in struct usb_ep") Signed-off-by: Zixun LI <[email protected]> Not: Fixes: 59310d1ecb9f ("usb: gadget: introduce 'enabled' flag in struct usb_ep") <empty newline> Signed-off-by: Zixun LI <[email protected]> No need to resend a v3 for it, I can fix it up while applying. > --- > Changes in v2: > - Remove outdated comment in usba_ep_disable() > - Reword commit message > - Link to v1: > https://patch.msgid.link/[email protected] > > To: Mattijs Korpershoek <[email protected]> > To: Stephan Gerhold <[email protected]> > To: [email protected] > Cc: Lukasz Majewski <[email protected]> > Cc: Marek Vasut <[email protected]> > Cc: Tom Rini <[email protected]> > Cc: Zixun LI <[email protected]> > Cc: Andrew Goodbody <[email protected]> > --- > drivers/usb/gadget/atmel_usba_udc.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/usb/gadget/atmel_usba_udc.c > b/drivers/usb/gadget/atmel_usba_udc.c > index f7a92ded6da..a2eee2bca2c 100644 > --- a/drivers/usb/gadget/atmel_usba_udc.c > +++ b/drivers/usb/gadget/atmel_usba_udc.c > @@ -289,10 +289,6 @@ static int usba_ep_disable(struct usb_ep *_ep) > > if (!ep->desc) { > spin_unlock_irqrestore(&udc->lock, flags); > - /* REVISIT because this driver disables endpoints in > - * reset_all_endpoints() before calling disconnect(), > - * most gadget drivers would trigger this non-error ... > - */ > if (udc->gadget.speed != USB_SPEED_UNKNOWN) > DBG(DBG_ERR, "ep_disable: %s not enabled\n", > ep->ep.name); > @@ -571,20 +567,6 @@ static void reset_all_endpoints(struct usba_udc *udc) > list_del_init(&req->queue); > request_complete(ep, req, -ECONNRESET); > } > - > - /* NOTE: normally, the next call to the gadget driver is in > - * charge of disabling endpoints... usually disconnect(). > - * The exception would be entering a high speed test mode. > - * > - * FIXME remove this code ... and retest thoroughly. > - */ > - list_for_each_entry(ep, &udc->gadget.ep_list, ep.ep_list) { > - if (ep->desc) { > - spin_unlock(&udc->lock); > - usba_ep_disable(&ep->ep); > - spin_lock(&udc->lock); > - } > - } > } > > static struct usba_ep *get_ep_by_addr(struct usba_udc *udc, u16 wIndex) > > --- > base-commit: 5732bd0f457b4c671e46574d64d4acb099c0f0a5 > change-id: 20260512-udc_ep-51a3f7a6befb > > Best regards, > -- > Zixun LI <[email protected]>
